This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix stale RR and improve LL reliability in RoomView & MemberList. #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more reliable with LL enabled as the syncing user is only known when it was active in the current timeline or when the members have been loaded
the spinner should only be shown when joined
_loadMembersIfJoined is called from _onRoomLoaded < _onRoomViewStoreUpdate, before incoming state from the store is applied to this.state, so looking up the room with this.state.roomId doesn't always work, which would cause the members not to be loaded. Pass in the room instead.
... once the members are loaded.
|
Ran the e2e tests locally as they fail on CI atm, ran successfully. |
dbkr
approved these changes
Sep 18, 2018
|
This seems to break the RoomList tests, having a look at that before merging. |
|
Waiting for matrix-org/matrix-react-end-to-end-tests#26 to make sure the build isn't broken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#735
Fixes element-hq/element-web#7326
Uses
Room.myMembershipevent to reliably know when we joined the room as we won't always get aRoomMember.membershipfor our own user with LL enabled.Also pass the members-loaded state to
TimelinePanelto make sure it re-renders after the members are loaded, so RR are re-rendered with all members known.