Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix exception when opening dev tools #1961

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 13, 2018

Apparently draft sometimes gets unhappy when you try to move to the
end of an empty state, so only move to the end if we actually
created a non-empty state.

This will be irrelevant once #1890
is merged, but I have the fix now, and this is probably otherwise
going to annoy me now I'm doing things where devtools is very useful.

Fixes element-hq/element-web#6436

Apparently draft sometimes gets unhappy when you try to move to the
end of an empty state, so only move to the end if we actually
created a non-empty state.

This will be irrelevant once #1890
is merged, but I have the fix now, and this is probably otherwise
going to annoy me now I'm doing things where devtools is very useful.

Fixes element-hq/element-web#6436
@lukebarnard1
Copy link
Contributor

This will inevitably conflict with #1890 so I'm not sure if it's worth merging it. The unknown is how quickly we can get #1890 reviewed and merged, and this will impact users on /develop between merging this and merging #1890. In conclusion shrugs.

@dbkr
Copy link
Member Author

dbkr commented Jun 14, 2018

Given it should be trivial to resolve the conflict, I'm going to merge it.

@dbkr
Copy link
Member Author

dbkr commented Jun 14, 2018

Looks like this causes everything to break, predictably enough. Sigh. Let's burn draft with fire.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing "/devtools" results in a draft error
2 participants