Acknowledge DeviceMute widget actions
#12790
Conversation
toger5
changed the title
DeviceMute widget actions
| @@ -21,8 +21,6 @@ export enum ElementWidgetActions { | |||
| JoinCall = "io.element.join", | |||
| HangupCall = "im.vector.hangup", | |||
| CallParticipants = "io.element.participants", | |||
| MuteAudio = "io.element.mute_audio", | |||
| UnmuteAudio = "io.element.unmute_audio", | |||
There was a problem hiding this comment.
yes I could not find where they were used in EC, the react sdk and the widget api.
There was a problem hiding this comment.
They were used by Jitsi.
If they were stale then they should have been removed on that side first
There was a problem hiding this comment.
Looks like 1f64835 stopped the use of those enum values
There was a problem hiding this comment.
@robintown as the author of that commit do you have any additional context?
There was a problem hiding this comment.
Looks like it powered a set of quick controls in the left panel which were removed
There was a problem hiding this comment.
element-hq/element-web#27858 should fix it
toger5
added
the
T-Enhancement
|
Can we allow this change without test coverage? I don't want to write a test that emits a signal and checks if reply is called? There might be a tiny bit of value in this test in terms of regression prevention but if someone removes this code it most likely is for a reason? Am I overseeing sth. What are other takes on this? |
|
The policy is code either needs Jest coverage or a playwright test up to an 80% mark to match customer contracts. Pick your poison unfortunately |
Okay that obviously rules out the "being less strict" approach. |
… error response to the widget)
toger5
force-pushed
the
toger5/ack-device-mute-widget-action
branch
from
d5256f7 to
14de45f
Compare
This prevents sending the default error response to the widget.
required for: element-hq/element-call#2482
Checklist
public/exportedsymbols have accurate TSDoc documentation.