This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tooltip: Improve the accessibility of the composer and the rich text editor #12459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
AccessibleButton for composer & rich text editor
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
cd23ca0
to
f49a9fd
Compare
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
f49a9fd
to
d84f003
Compare
florianduros
added
the
T-Enhancement
# Conflicts: # src/accessibility/roving/RovingAccessibleTooltipButton.tsx
florianduros
changed the title
AccessibleButton for composer & rich text editor
florianduros
changed the title
t3chguy
reviewed
Apr 30, 2024
There was a problem hiding this comment.
The changes here feel like a visual regression, can design sign off on losing the keyboard key styling here?
There was a problem hiding this comment.
Actually my bad, there's no visual regression, only an a11y one. The kbd elements are lost and thus also are the semantics
Before:
There was a problem hiding this comment.
Good catch, will need to update the tooltip compound to be able this use case.
This was referenced May 3, 2024
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
feb19b9
to
df840fe
Compare
florianduros
force-pushed
the
florianduros/tooltip/composer
branch
from
df840fe
to
64f1ab0
Compare
florianduros
changed the title
t3chguy
approved these changes
May 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 22, 2024
https://build.opensuse.org/request/show/1175893 by user dheidler + anag+factory - Version 1.11.67 ## ✨ Features * Tooltip: Improve the accessibility of the composer and the rich text editor (matrix-org/matrix-react-sdk#12459). Contributed by @florianduros. * Allow explicit configuration of OIDC dynamic registration metadata (matrix-org/matrix-react-sdk#12514). Contributed by @t3chguy. * Tooltip: improve accessibility for messages (matrix-org/matrix-react-sdk#12487). Contributed by @florianduros. * Collapse UserSettings tabs to just icons on narrow screens (matrix-org/matrix-react-sdk#12505). Contributed by @dbkr. * Add room topic to right panel room info (matrix-org/matrix-react-sdk#12503). Contributed by @t3chguy. * OIDC: pass `id_token
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 22, 2024
https://build.opensuse.org/request/show/1175898 by user dheidler + anag+factory - Version 1.11.67 ## ✨ Features * Tooltip: Improve the accessibility of the composer and the rich text editor (matrix-org/matrix-react-sdk#12459). Contributed by @florianduros. * Allow explicit configuration of OIDC dynamic registration metadata (matrix-org/matrix-react-sdk#12514). Contributed by @t3chguy. * Tooltip: improve accessibility for messages (matrix-org/matrix-react-sdk#12487). Contributed by @florianduros. * Collapse UserSettings tabs to just icons on narrow screens (matrix-org/matrix-react-sdk#12505). Contributed by @dbkr. * Add room topic to right panel room info (matrix-org/matrix-react-sdk#12503). Contributed by @t3chguy. * OIDC: pass `id_token
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 6, 2024
Changes in [1.11.69](https://github.com/element-hq/element-web/releases/tag/v1.11.69) (2024-06-18) ================================================================================================== ## ✨ Features * Change avatar setting component to use a menu ([#12585](matrix-org/matrix-react-sdk#12585)). Contributed by @dbkr. * New user profile UI in User Settings ([#12548](matrix-org/matrix-react-sdk#12548)). Contributed by @dbkr. * MSC4108 support OIDC QR code login ([#12370](matrix-org/matrix-react-sdk#12370)). Contributed by @t3chguy. ## 🐛 Bug Fixes * Fix image upload preview size ([#12612](matrix-org/matrix-react-sdk#12612)). Contributed by @RiotRobot. * Fix screen sharing in recent Chrome (matrix-org/matrix-js-sdk#4243). * Fix roving tab index crash `compareDocumentPosition` ([#12594](matrix-org/matrix-react-sdk#12594)). Contributed by @t3chguy. * Keep dialog glass border on narrow screens ([#12591](matrix-org/matrix-react-sdk#12591)). Contributed by @dbkr. * Add missing a11y label to dismiss onboarding button in room list ([#12587](matrix-org/matrix-react-sdk#12587)). Contributed by @t3chguy. * Add hover / active state on avatar setting upload button ([#12590](matrix-org/matrix-react-sdk#12590)). Contributed by @dbkr. * Fix EditInPlace button styles ([#12589](matrix-org/matrix-react-sdk#12589)). Contributed by @dbkr. * Fix incorrect assumptions about required fields in /search response ([#12575](matrix-org/matrix-react-sdk#12575)). Contributed by @t3chguy. * Fix display of no avatar in avatar setting controls ([#12558](matrix-org/matrix-react-sdk#12558)). Contributed by @dbkr. * Element-R: pass pickleKey in as raw key for indexeddb encryption ([#12543](matrix-org/matrix-react-sdk#12543)). Contributed by @richvdh. Changes in [1.11.68](https://github.com/element-hq/element-web/releases/tag/v1.11.68) (2024-06-04) ================================================================================================== ## ✨ Features * Tooltip: Improve accessibility for context menus ([#12462](matrix-org/matrix-react-sdk#12462)). Contributed by @florianduros. * Tooltip: Improve accessibility of space panel ([#12525](matrix-org/matrix-react-sdk#12525)). Contributed by @florianduros. ## 🐛 Bug Fixes * Close the release announcement when a dialog is opened ([#12559](matrix-org/matrix-react-sdk#12559)). Contributed by @florianduros. * Tooltip: close field tooltip when ESC is pressed ([#12553](matrix-org/matrix-react-sdk#12553)). Contributed by @florianduros. * Fix tabbedview breakpoint width ([#12556](matrix-org/matrix-react-sdk#12556)). Contributed by @dbkr. * Fix E2E icon display in room header ([#12545](matrix-org/matrix-react-sdk#12545)). Contributed by @florianduros. * Tooltip: Improve placement for space settings ([#12541](matrix-org/matrix-react-sdk#12541)). Contributed by @florianduros. * Fix deformed avatar in a call in a narrow timeline ([#12538](matrix-org/matrix-react-sdk#12538)). Contributed by @florianduros. * Shown own sent state indicator even when showReadReceipts is disabled ([#12540](matrix-org/matrix-react-sdk#12540)). Contributed by @t3chguy. * Ensure we do not fire the verification mismatch modal multiple times ([#12526](matrix-org/matrix-react-sdk#12526)). Contributed by @t3chguy. * Fix avatar in chat export ([#12537](matrix-org/matrix-react-sdk#12537)). Contributed by @florianduros. * Use `*` for italics as it doesn't break when used mid-word ([#12523](matrix-org/matrix-react-sdk#12523)). Contributed by @t3chguy. Changes in [1.11.67](https://github.com/element-hq/element-web/releases/tag/v1.11.67) (2024-05-22) ================================================================================================== ## ✨ Features * Tooltip: Improve the accessibility of the composer and the rich text editor ([#12459](matrix-org/matrix-react-sdk#12459)). Contributed by @florianduros. * Allow explicit configuration of OIDC dynamic registration metadata ([#12514](matrix-org/matrix-react-sdk#12514)). Contributed by @t3chguy. * Tooltip: improve accessibility for messages ([#12487](matrix-org/matrix-react-sdk#12487)). Contributed by @florianduros. * Collapse UserSettings tabs to just icons on narrow screens ([#12505](matrix-org/matrix-react-sdk#12505)). Contributed by @dbkr. * Add room topic to right panel room info ([#12503](matrix-org/matrix-react-sdk#12503)). Contributed by @t3chguy. * OIDC: pass `id_token` via `id_token_hint` on Manage Account interaction ([#12499](matrix-org/matrix-react-sdk#12499)). Contributed by @t3chguy. * Tooltip: improve accessibility in room ([#12493](matrix-org/matrix-react-sdk#12493)). Contributed by @florianduros. * Tooltip: improve accessibility for call and voice messages ([#12489](matrix-org/matrix-react-sdk#12489)). Contributed by @florianduros. * Move the active tab in user settings to the dialog title ([#12481](matrix-org/matrix-react-sdk#12481)). Contributed by @dbkr. * Tooltip: improve accessibility of spaces ([#12497](matrix-org/matrix-react-sdk#12497)). Contributed by @florianduros. * Tooltip: improve accessibility of the right panel ([#12490](matrix-org/matrix-react-sdk#12490)). Contributed by @florianduros. * MSC3575 (Sliding Sync) add well-known proxy support ([#12307](matrix-org/matrix-react-sdk#12307)). Contributed by @EdGeraghty. ## 🐛 Bug Fixes * Reuse single PlaybackWorker between Playback instances ([#12520](matrix-org/matrix-react-sdk#12520)). Contributed by @t3chguy. * Fix well-known lookup for sliding sync labs check ([#12519](matrix-org/matrix-react-sdk#12519)). Contributed by @t3chguy. * Fix `element-desktop-ssoid being` included in OIDC Authorization call ([#12495](matrix-org/matrix-react-sdk#12495)). Contributed by @t3chguy. * Fix beta notifications reconciliation for intentional mentions push rules ([#12510](matrix-org/matrix-react-sdk#12510)). Contributed by @t3chguy. * fix avatar stretched on 1:1 call ([#12494](matrix-org/matrix-react-sdk#12494)). Contributed by @I-lander. * Check native sliding sync support against an unstable feature flag ([#12498](matrix-org/matrix-react-sdk#12498)). Contributed by @turt2live. * Use OPTIONS for sliding sync detection poke ([#12492](matrix-org/matrix-react-sdk#12492)). Contributed by @turt2live. * TAC: hide tooltip when the release announcement is displayed ([#12472](matrix-org/matrix-react-sdk#12472)). Contributed by @florianduros. Changes in [1.11.66](https://github.com/element-hq/element-web/releases/tag/v1.11.66) (2024-05-07) ================================================================================================== ## ✨ Features * Use a different error message for UTDs when you weren't in the room. ([#12453](matrix-org/matrix-react-sdk#12453)). Contributed by @uhoreg. * Take the Threads Activity Centre out of labs ([#12439](matrix-org/matrix-react-sdk#12439)). Contributed by @dbkr. * Expected UTDs: use a different message for UTDs sent before login ([#12391](matrix-org/matrix-react-sdk#12391)). Contributed by @richvdh. * Add `Tooltip` to `AccessibleButton` ([#12443](matrix-org/matrix-react-sdk#12443)). Contributed by @florianduros. * Add analytics to activity toggles ([#12418](matrix-org/matrix-react-sdk#12418)). Contributed by @dbkr. * Decrypt events in reverse order without copying the array ([#12445](matrix-org/matrix-react-sdk#12445)). Contributed by @Johennes. * Use new compound tooltip ([#12416](matrix-org/matrix-react-sdk#12416)). Contributed by @florianduros. * Expected UTDs: report a different Posthog code ([#12389](matrix-org/matrix-react-sdk#12389)). Contributed by @richvdh. ## 🐛 Bug Fixes * TAC: Fix accessibility issue when the Release announcement is displayed ([#12484](matrix-org/matrix-react-sdk#12484)). Contributed by @RiotRobot. * TAC: Close Release Announcement when TAC button is clicked ([#12485](matrix-org/matrix-react-sdk#12485)). Contributed by @florianduros. * MenuItem: fix caption usage ([#12455](matrix-org/matrix-react-sdk#12455)). Contributed by @florianduros. * Show the local echo in previews ([#12451](matrix-org/matrix-react-sdk#12451)). Contributed by @langleyd. * Fixed the drag and drop of X #27186 ([#12450](matrix-org/matrix-react-sdk#12450)). Contributed by @asimdelvi. * Move the TAC to above the button ([#12438](matrix-org/matrix-react-sdk#12438)). Contributed by @dbkr. * Use the same logic in previews as the timeline to hide events that should be hidden ([#12434](matrix-org/matrix-react-sdk#12434)). Contributed by @langleyd. * Fix selector so maths support doesn't mangle divs ([#12433](matrix-org/matrix-react-sdk#12433)). Contributed by @uhoreg.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
Following #12443,
AccessibleButtonincludes the new tooltip. We are migrating step by step the usage of the deprecatedAccessibleTooltipButtontoAccessibleButton.Depends of #12458 for
RovingAccessibleTooltipButtonmigration.Depends of element-hq/compound-web#165 to use
<kbd />for shortcut in tooltips of formatting buttons.Marking it at
T-Enhancementbecause it's in the objective to improve accessibility.Migrating both composer.