This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add caption for empty TAC#12226
Merged
dbkr merged 3 commits intoflorianduros/threads/pop-out-panelfrom Feb 6, 2024
Merged
Conversation
dbkr
added
the
T-Defect
dbkr
requested review from
MidhunSureshR and
florianduros
and removed request for
a team
florianduros
suggested changes
Feb 5, 2024
Contributor
florianduros
left a comment
florianduros
left a comment
There was a problem hiding this comment.
Thx!
Can we have a small unit test for this case?
florianduros
reviewed
Feb 5, 2024
src/i18n/strings/en_EN.json
Outdated
| "empty": "You don't currently have any stickerpacks enabled", | ||
| "empty_add_prompt": "Add some now" | ||
| }, | ||
| "tac": { |
Contributor
There was a problem hiding this comment.
A threads_activity_centre category is available in the lang json
florianduros
approved these changes
Feb 6, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/element-hq/wat-internal/issues/146
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes