Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Feb 1, 2024

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr requested a review from a team as a code owner February 1, 2024 18:23
@dbkr dbkr requested review from MidhunSureshR and florianduros and removed request for a team February 1, 2024 18:23
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 1, 2024
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

What do you think about to add jest snapshot to the test?

@dbkr
Copy link
Member Author

dbkr commented Feb 2, 2024

Yeah, I guess there's no reason not to add a snapshot

@dbkr dbkr merged commit f9608c0 into florianduros/threads/pop-out-panel Feb 2, 2024
@dbkr dbkr deleted the dbkr/tac_test branch February 2, 2024 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants