This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Improve AccessibleButton & related types#12075
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
added
the
T-Task
richvdh
approved these changes
Dec 20, 2023
Comment on lines
24
to
25
| // omitted props are handled by render function | ||
| interface IProps extends Omit<React.ComponentProps<typeof AccessibleTooltipButton>, "title" | "onClick" | "disabled"> { | ||
| type Props = Omit<ComponentProps<typeof AccessibleTooltipButton>, "title" | "onClick" | "disabled" | "element"> & { |
Member
There was a problem hiding this comment.
Is element omitted here because a PlayPauseButton can only ever be based on the default element type (div)?
Not entirely convinced that the comment here is accurate; or indeed giving any value. Maybe remove it?
Member
Author
There was a problem hiding this comment.
can only ever be based on the default element type (div)?
Indeed, really I'm not sure this should be extending ComponentProps and instead should just list the ones it wants given it isn't a generic reusable component but I thought I'd apply a consistent approach rather than dig into less relevant things
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #12054
This change is marked as an internal change (Task), so will not be included in the changelog.