This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix regression around FacePile with overflow #11527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
X-Release-Blocker
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nurjinjafar
pushed a commit
to nordeck/matrix-react-sdk
that referenced
this pull request
Sep 6, 2023
* Work around compound-web AvatarStack not applying overlap to non-Avatars * Fix FacePile overflow tile not being layed out correctly
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Implement denied request mask and logic Signed-off-by: AHMAD KADRI <[email protected]> * refactor / fix deny requests isues * fix tests create denied message test Signed-off-by: AHMAD KADRI <[email protected]> * add another test for the primary action for denied request Signed-off-by: AHMAD KADRI <[email protected]> * fix linter issues Signed-off-by: nurjinn jafar <[email protected]> * regenerate translation Signed-off-by: nurjinn jafar <[email protected]> * fix translation and minor refactoring Signed-off-by: nurjinn jafar <[email protected]> * segment into 4 * Remove parallel from Cypress command to avoid talking to Cypress Cloud * Re-add --parallel flag for Percy * Prevent event propagation when clicking icon buttons (#11515) * Prevent event propagation when clicking icon buttons * Inhibit view user on click behaviour for room header face pile * Update snapshot * Add a 'm.relates_to' to edits in receipt tests and disable failing tests (#11501) * Add a 'm.relates_to' to edits in receipt tests * Disable a test that fails with real edits * Wait for the room to be read after we mark it as read * Skip tests that are failing because of inconsistencies between local and CI behaviour * Allow creating public knock rooms (#11481) * Allow creating public knock rooms Signed-off-by: Charly Nguyen <[email protected]> * Apply PR feedback Signed-off-by: Charly Nguyen <[email protected]> * Apply PR feedback Signed-off-by: Charly Nguyen <[email protected]> --------- Signed-off-by: Charly Nguyen <[email protected]> * Collect `console.debug` logs during cypress tests (#11478) In order for the logs collected by cypress to actually be useful, we really need `cons:debug`. * Migrate more strings to translation keys (#11522) * Only show Search button in RoomSummaryCard if new room UI enabled (#11524) * Only show Search button in RoomSummaryCard if new room UI enabled * Update snapshot * Update vector-im (#11526) * Update vector-im * Update snapshots of Compound Avatars * Update snapshots of Compound Avatars --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]> * Migrate more strings to translation keys (#11530) * Fix regression around FacePile with overflow (#11527) * Work around compound-web AvatarStack not applying overlap to non-Avatars * Fix FacePile overflow tile not being layed out correctly * Use RoomStateEvent.Update for knocks (#11516) Signed-off-by: Charly Nguyen <[email protected]> * Cypress tests for event shields (#11525) * Factor downloadKey out to `utils.ts` * Add a new `describe` block for event shields * create a beforeEach block * Cypress tests for event shields * Document how to match the CI config for Cypress (#11531) * Document how to match the CI config for Cypress * Clarify language about needing Chrome * Move Cypress info into the Cypress-specific docs * Migrate more strings to translation keys (#11532) --------- Signed-off-by: AHMAD KADRI <[email protected]> Signed-off-by: nurjinn jafar <[email protected]> Signed-off-by: Charly Nguyen <[email protected]> Co-authored-by: AHMAD KADRI <[email protected]> Co-authored-by: Kerry Archibald <[email protected]> Co-authored-by: Andy Balaam <[email protected]> Co-authored-by: Johannes Marbach <[email protected]> Co-authored-by: Germain <[email protected]> Co-authored-by: Charly Nguyen <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
germain-gg
pushed a commit
that referenced
this pull request
Sep 20, 2023
This reverts commit 93ccccc.
3 tasks
andybalaam
added a commit
that referenced
this pull request
Sep 26, 2023
Revert "Fix regression around FacePile with overflow (#11527)"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26112
Related element-hq/compound#215
This change is marked as an internal change (Task), so will not be included in the changelog.