Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Stabilize support for MSC3952: intentional mentions #10967

Merged
merged 9 commits into from
Jul 11, 2023
Merged

Stabilize support for MSC3952: intentional mentions #10967

merged 9 commits into from
Jul 11, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented May 23, 2023 •
edited by github-actions bot
Loading

With matrix-org/matrix-js-sdk#3397
For element-hq/element-web#25267

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 23, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review July 3, 2023 03:52
@kerryarchibald kerryarchibald requested a review from a team as a code owner July 3, 2023 03:52
richvdh
richvdh approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is sad (is your js-sdk branch old?) but lgtm

@kerryarchibald kerryarchibald added this pull request to the merge queue Jul 11, 2023
Merged via the queue into develop with commit c5befa1 Jul 11, 2023
@kerryarchibald kerryarchibald deleted the kerry/25267/intentional-mentions-stable branch July 11, 2023 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @richvdh