This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Pass push rules through rewriteDefaultRules for compatibility with matrix-js-sdk#3134. #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trix-js-sdk#3134.
clokep
added
the
T-Task
3 tasks
clokep
added
T-Task
|
We're going to try this without modifying the interface. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the tests in matrix-js-sdk#3134. I think the test this is modifying was doing things somewhat incorrectly, but it isn't clear to me if you should be able to directly munge push rules. (If so, I suspect this was breakable even before matrix-org/matrix-js-sdk#3134).
Checklist
[ ] Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.