Fix tooltip infinitely recursing (#9235)

matrix-org · Sep 2, 2022 · 3e8da6f · 3e8da6f
1 parent d1237b2
commit 3e8da6f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/components/views/elements/Tooltip.tsx b/src/components/views/elements/Tooltip.tsx
@@ -22,6 +22,7 @@ import ReactDOM from 'react-dom';
 import classNames from 'classnames';
 
 import UIStore from "../../../stores/UIStore";
+import { objectHasDiff } from "../../../utils/objects";
 
 export enum Alignment {
     Natural, // Pick left or right
@@ -91,8 +92,10 @@ export default class Tooltip extends React.PureComponent<ITooltipProps, State> {
         this.updatePosition();
     }
 
-    public componentDidUpdate() {
-        this.updatePosition();
+    public componentDidUpdate(prevProps) {
+        if (objectHasDiff(prevProps, this.props)) {
+            this.updatePosition();
+        }
     }
 
     // Remove the wrapper element, as the tooltip has finished using it