try a hunch to fix https://github.com/vector-im/riot-web/issues/6212 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by deleting fields from /sync responses as you emit them into events, to avoid wasting RAM when parsing the enormous accumulated sync response from indexeddb on launch
|
i haven't been able to test this yet as my initial sync won't complete (been waiting 10 minutes now), but if my theory at element-hq/element-web#6212 (comment) is right, it might help a bit? |
|
was the IRL conclusion that this wouldn't help because they were being retained elsewhere? |
|
yeah, it was. the Promises.series() stuff was holding onto a reference, although if you've killed that it might work quite nicely? |
|
I didn't, but I could try that. |
|
Assuming this is probably unnecessary now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by deleting fields from /sync responses as you emit them into events,
to avoid wasting RAM when parsing the enormous accumulated sync response
from indexeddb on launch