Update fetch-mock-jest to @fetch-mock/jest#5136
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This test failed when ran individually, same as after the clearAllMocks call Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…ny other way Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…ch-mock & fix typo Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/fetch-mock
branch
from
ee46e52 to
c58f6cc
Compare
t3chguy
force-pushed
the
t3chguy/fetch-mock
branch
2 times, most recently
from
c6e888f to
dcf7bd9
Compare
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/fetch-mock
branch
from
dcf7bd9 to
758439b
Compare
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
requested review from
MidhunSureshR,
andybalaam,
hughns and
uhoreg
and removed request for
a team
andybalaam
approved these changes
Jan 13, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks reasonable and OK from a Crypto point of view.
dbkr
approved these changes
Jan 13, 2026
…chguy/fetch-mock # Conflicts: # spec/integ/crypto/cross-signing.spec.ts # spec/integ/crypto/state-events.spec.ts # spec/unit/oidc/authorize.spec.ts # spec/unit/rust-crypto/rust-crypto.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plucked out from #5131
Depends on #5137
Any odd type-assertions are due to
@fetch-mock/jesttypes being weak and kicking in on generics & unknown types, resulting in the available assertions going away. The types for extending assertions seem not to have this issue in vitest but given I was asked to split the jest->vitest PR here we are.No clue how but this upgrade broke the comparisons between objects in the test & the unit under test contexts so had to temporarily patch
deepCompare- this is reverted in #5131