Support for creator power level #4937

dbkr · 2025-07-23T14:56:10Z

Adds support for infinite power level specified by MSC4289.

This version removes powerLevelNorm which we only use in one place in Element Web (where we probably should not) and I'm not sure is generally that sensible, so I've removed it since it's a difficult concept to keep and would at best be a slight lie when one of the PLs is always infinity (eg. we'd have to say creator is also 100, probably). This makes this a BREAKING CHANGE.

I'll leave this as draft until I have a matching PR for element.

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
Sign-off given on the changes (see CONTRIBUTING.md).

Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289).

src/models/room-member.ts

src/models/room-state.ts

src/models/room.ts

as room versions strings aren't ordered

t3chguy · 2025-07-31T15:17:22Z

@dbkr did you mean to request review? it is still in draft

Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937

dbkr · 2025-07-31T17:40:36Z

well, I was still doing the element web PR but figured it could go through review at least

* Update for compatibility with v12 rooms Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937 * Add test for leave space dialog * Don't compute stuff if we don't need it * Use room.client * Use getSafeUserId * Remove client arg * Use getJoinedMembers and add doc * Fix tests * Fix more tests * Fix other test * Clarify comment Co-authored-by: Michael Telatynski <[email protected]> --------- Co-authored-by: Michael Telatynski <[email protected]>

Follows on from #4937

MidhunSureshR

Looks great, just two minor things!

src/models/room-member.ts

src/models/room-state.ts

t3chguy

This will need deprecating first, this PR should be rebased to vNext

t3chguy · 2025-08-06T09:02:19Z

src/models/room-member.ts

     * Fires {@link RoomMemberEvent.PowerLevel}
     */
-    public setPowerLevelEvent(powerLevelEvent: MatrixEvent): void {
+    public setPowerLevelEvent(powerLevelEvent: MatrixEvent, roomCreateEvent: MatrixEvent, roomVersion: string): void {


Having to pass the roomVersion & roomCreateEvent feels like a really odd signature, IMO RoomMember should know its room, it should probably be a c'tor param it holds onto then it can get these itself.

This will be a pretty significant change which will also need RoomState to know about the room it's for as it has to construct RoomMembers. The thinking here was that you pass all the inputs into the function rather than it taking some from the state which hopefully makes it easier to reason about and less magic, plus just wanting to keep the class as pure as possible and not knowing anything about the context it exists in, only what it represents itself. Admittedly it does make the function signature a little odd: I was going to rename it to something that reflected it taking all the information that affected power levels but I didn't feel like it helped a great deal.

I feel like its a massive footgun like setPowerLevel used to be on MatrixClient back when you needed to pass in the existing power level event. We had a bunch of issues about people holding it wrong. I think the RoomState holding the Room object is very sane.

Alternatively the logic could be hoisted into RoomState where it lives in a private method and RoomMember just blindly trusts the powerLevel you give it, rather than needing the whole event. Either way its a breaking change.

Well, this is all breaking change unfortunately: hydra sort of necessitates it. I'm not sure people holding it wrong is really a concern here? This isn't really public facing API.

I'm very reluctant to block our hydra changes on a significant refactor of a part of js-sdk's data model: i think this would add significant risk to our hydra deadline. I can look at moving it RoomState.

It appears as public in the API docs https://matrix-org.github.io/matrix-js-sdk/classes/matrix.RoomMember.html#setpowerlevelevent

Assume unknown room versions do use hydra

dbkr · 2025-08-07T16:00:22Z

@t3chguy @richvdh sorry to prod but we really need to get something merged soon.

src/utils/roomVersion.ts

Co-authored-by: Richard van der Hoff <[email protected]>

src/utils/roomVersion.ts

* Support for creator power level Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289). * Update unit test * Hardcode versions as room versions strings aren't ordered * Add test for v12 rooms * Use more compact syntax Co-authored-by: R Midhun Suresh <[email protected]> * Fix doc Co-authored-by: R Midhun Suresh <[email protected]> * Fix additionalCreators from PR edit * Split out hydra room version check * Move power level logic into room state Which already has knowledge of the room create event * Add docs * Fix unused bits * Fix docs * Fix lying docstring * Reverse logic for hydra semantics Assume unknown room versions do use hydra * Use backticks Co-authored-by: Richard van der Hoff <[email protected]> * Switch back to hardcoding just the two hydra versions --------- Co-authored-by: R Midhun Suresh <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> (cherry picked from commit e119bf9)

Follows on from #4937

Follows on from #4937 (cherry picked from commit dea184e)

* Support for creator power level Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289). * Update unit test * Hardcode versions as room versions strings aren't ordered * Add test for v12 rooms * Use more compact syntax * Fix doc * Fix additionalCreators from PR edit * Split out hydra room version check * Move power level logic into room state Which already has knowledge of the room create event * Add docs * Fix unused bits * Fix docs * Fix lying docstring * Reverse logic for hydra semantics Assume unknown room versions do use hydra * Use backticks * Switch back to hardcoding just the two hydra versions --------- (cherry picked from commit e119bf9) Co-authored-by: David Baker <[email protected]> Co-authored-by: R Midhun Suresh <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]>

Follows on from #4937 (cherry picked from commit dea184e) Co-authored-by: David Baker <[email protected]>

This inverts the check for whether to use hydra semantics to only NOT use it for known, old room versions and use hydra for everything else, so rooms with versions we don't know about will use hydra semantics. This will cause any rooms using old/experiental versions unknown to the js-sdk to break, but will mean that wehn the next room version comes out, we'll use hydra for it which is, of course, not a given, but is way more likely than going back to the old semantics. The mobile Element clients currently hardcode hydra versions (ie. as it is without this change, but we expect them to make this same change soon after the hydra release. We do NOT expect this to land with the hydra release, but target it for the release after. Reverts 1e5054a from #4937 See element-hq/element-meta#2921 for public discussion.

* Update for compatibility with v12 rooms Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937 * Add test for leave space dialog * Don't compute stuff if we don't need it * Use room.client * Use getSafeUserId * Remove client arg * Use getJoinedMembers and add doc * Fix tests * Fix more tests * Fix other test * Clarify comment Co-authored-by: Michael Telatynski <[email protected]> --------- Co-authored-by: Michael Telatynski <[email protected]>

Support for creator power level

62fae9a

Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289).

dbkr added the T-Enhancement label Jul 23, 2025

github-actions bot deployed to PR Documentation Preview July 23, 2025 14:57 View deployment

Update unit test

45296b9

github-actions bot deployed to PR Documentation Preview July 23, 2025 15:04 View deployment

t3chguy requested changes Jul 23, 2025

View reviewed changes

src/models/room-member.ts Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Jul 23, 2025

View reviewed changes

src/models/room-state.ts Fixed Show fixed Hide fixed

src/models/room.ts Fixed Show fixed Hide fixed

Hardcode versions

54b30cb

as room versions strings aren't ordered

github-actions bot deployed to PR Documentation Preview July 23, 2025 16:37 View deployment

Add test for v12 rooms

a4ac412

github-actions bot deployed to PR Documentation Preview July 23, 2025 17:08 View deployment

dbkr added the X-Breaking-Change label Jul 23, 2025

dbkr requested a review from t3chguy July 31, 2025 14:42

dbkr added a commit to element-hq/element-web that referenced this pull request Jul 31, 2025

Update for compatibility with v12 rooms

3eca1de

Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937

dbkr mentioned this pull request Jul 31, 2025

Update for compatibility with v12 rooms element-hq/element-web#30452

Merged

4 tasks

Merge branch 'develop' into dbkr/hydra

09c67d9

github-actions bot deployed to PR Documentation Preview July 31, 2025 17:42 View deployment

dbkr marked this pull request as ready for review August 5, 2025 11:44

dbkr requested a review from a team as a code owner August 5, 2025 11:44

dbkr requested a review from MidhunSureshR August 5, 2025 11:44

dbkr added a commit that referenced this pull request Aug 5, 2025

Support v12 rooms in maySendEvent

34b0964

Follows on from #4937

dbkr mentioned this pull request Aug 5, 2025

Support v12 rooms in maySendEvent #4946

Closed

4 tasks

MidhunSureshR approved these changes Aug 6, 2025

View reviewed changes

src/models/room-member.ts Outdated Show resolved Hide resolved

src/models/room-state.ts Outdated Show resolved Hide resolved

t3chguy requested changes Aug 6, 2025

View reviewed changes

t3chguy reviewed Aug 6, 2025

View reviewed changes

Reverse logic for hydra semantics

a9dc88f

Assume unknown room versions do use hydra

github-actions bot deployed to PR Documentation Preview August 7, 2025 14:50 View deployment

richvdh approved these changes Aug 7, 2025

View reviewed changes

src/utils/roomVersion.ts Outdated Show resolved Hide resolved

Use backticks

c8c32b8

Co-authored-by: Richard van der Hoff <[email protected]>

github-actions bot deployed to PR Documentation Preview August 8, 2025 08:32 View deployment

t3chguy requested changes Aug 8, 2025

View reviewed changes

src/utils/roomVersion.ts Show resolved Hide resolved

Switch back to hardcoding just the two hydra versions

1e5054a

github-actions bot deployed to PR Documentation Preview August 8, 2025 09:56 View deployment

t3chguy approved these changes Aug 8, 2025

View reviewed changes

dbkr added this pull request to the merge queue Aug 8, 2025

Merged via the queue into develop with commit e119bf9 Aug 8, 2025
32 checks passed

dbkr deleted the dbkr/hydra branch August 8, 2025 10:47

dbkr added the backport staging Label to automatically backport PR to staging branch label Aug 8, 2025

RiotRobot mentioned this pull request Aug 8, 2025

[Backport staging] Support for creator power level #4954

Merged

dbkr added a commit that referenced this pull request Aug 8, 2025

Support v12 rooms in maySendEvent

455ef57

Follows on from #4937

dbkr mentioned this pull request Aug 8, 2025

Support v12 rooms in maySendEvent #4955

Merged

4 tasks

github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2025

Support v12 rooms in maySendEvent (#4955)

dea184e

Follows on from #4937

RiotRobot pushed a commit that referenced this pull request Aug 8, 2025

Support v12 rooms in maySendEvent (#4955)

579efd9

Follows on from #4937 (cherry picked from commit dea184e)

dbkr added a commit that referenced this pull request Aug 8, 2025

Support v12 rooms in maySendEvent (#4955) (#4956)

f1ba8a8

Follows on from #4937 (cherry picked from commit dea184e) Co-authored-by: David Baker <[email protected]>

Uh oh!

Support for creator power level #4937

Support for creator power level #4937

Uh oh!

Conversation

dbkr commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

t3chguy commented Jul 31, 2025

Uh oh!

dbkr commented Jul 31, 2025

Uh oh!

MidhunSureshR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

t3chguy left a comment

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dbkr commented Jul 23, 2025 •

edited

Loading