-
-
Notifications
You must be signed in to change notification settings - Fork 652
Experimental support for sharing encrypted history on invite #4920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff0c9a8 to
361b0a1
Compare
Have `E2EKeyReceiver` collect uploaded cross-signing keys, so that they can be returned by `E2EKeyResponder`.
Have `E2EKeyReceiver` collect uploaded device signatures, so that they can be returned by `E2EKeyResponder`.
A new test helper, which intercepts `/keys/claim`, allowing clients under test to claim OTKs uploaded by other devices.
Add options to `MatrixClient.invite` and `MatrixClient.joinRoom` to share and accept encrypted history on invite, per MSC4268.
361b0a1 to
578cf42
Compare
t3chguy
reviewed
Jul 28, 2025
t3chguy
approved these changes
Jul 29, 2025
uhoreg
approved these changes
Jul 29, 2025
Member
uhoreg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Hubert Chathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to
MatrixClient.inviteandMatrixClient.joinRoomto share and accept encrypted history on invite, per MSC4268.There are some extensions to the test infrastructure to allow it to be properly integration tested: it may be easier to review commit-by-commit.
Part of element-hq/element-meta#2871.