Remove deprecated parameters and types in CryptoApi#4670
Remove deprecated parameters and types in CryptoApi#4670florianduros wants to merge 17 commits intodevelopfrom
CryptoApi#4670Conversation
…crypto/call Remove deprecated calls in `webrtc/call.ts`
* chore(legacy call): Remove `DeviceInfo` usage * refactor(legacy call): throw `GroupCallUnknownDeviceError` at the end of `initOpponentCrypto`
* feat(legacy crypto)!: remove deprecated methods of `MatrixClient`
* test(legacy crypto): update existing tests to not use legacy crypto
- `Embedded.spec.ts`: casting since `encryptAndSendToDevices` is removed from `MatrixClient`.
- `room.spec.ts`: remove deprecated usage of `MatrixClient.crypto`
- `matrix-client.spec.ts` & `matrix-client-methods.spec.ts`: remove calls of deprecated methods of `MatrixClient`
* test(legacy crypto): remove test files using `MatrixClient` deprecated methods
* test(legacy crypto): update existing integ tests to run successfully
* feat(legacy crypto!): remove `ICreateClientOpts.deviceToImport`.
`ICreateClientOpts.deviceToImport` was used in the legacy cryto. The rust crypto doesn't support to import devices in this way.
* feat(legacy crypto!): remove `{get,set}GlobalErrorOnUnknownDevices`
`globalErrorOnUnknownDevices` is not used in the rust-crypto. The API is marked as unstable, we can remove it.
florianduros
changed the title
CryptoApiCryptoApi
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/clean-up-crypto-api
branch
from
2693c9c to
644185d
Compare
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
I'm a bit nervous about this: it goes quite a long way beyond "remove legacy crypto", imho. For example findVerificationRequestDMInProgress and storeSessionBackupPrivateKey work ok in rust crypto.
Not saying we shouldn't plan to remove them, but I don't think we should do it as part of this change.
Removing the old DecryptionFailureCodes and CryptoCallbacks seems sensible.
Also, the tests are failing.
|
The legacy crypto tests are failing because of #4659. If we plan to remove them, should be in the same release than the removal of the legacy crypto in order to avoir too many releases with breaking changes. Or do we want to do in some weeks/month? |
I'm not really sure yet. Right now, I'm mostly nervous that we're making sweeping changes without effective CI. To be honest, I think we should leave it for a release or two; maybe get a working Either way: not part of this PR, please? |
|
I move it back to draft, we will resuscitate it if we need it later |
|
@florianduros I think this got (mostly) superceded? Can we close it? |
|
@richvdh Yes :) |
2 participants
Remove deprecated parameters in
CryptoApiand update rust-crypto .