Conversation
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/add-crypto-api-getbackupinfo
branch
from
2d5b1fb to
bd75c71
Compare
…ypto-api-getbackupinfo
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/add-crypto-api-getbackupinfo
branch
2 times, most recently
from
1103cf0 to
3a17421
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/add-crypto-api-getbackupinfo
branch
2 times, most recently
from
34f63bc to
34f9785
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/add-crypto-api-getbackupinfo
branch
from
34f9785 to
2a19422
Compare
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
Looks fine, but Rich will know the context.
|
@andybalaam Yep thx! I'm waiting for his opinion about it |
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
needs better documentation please!
src/crypto-api/index.ts
Outdated
| isKeyBackupTrusted(info: KeyBackupInfo): Promise<BackupTrustInfo>; | ||
|
|
||
| /** | ||
| * Get information about the current key backup. |
There was a problem hiding this comment.
We should define what "current" means here. The version we are currently using for automatic backup? The version we are currently using for automatic restore? The most recent backup on the server? Most recent on the server when we last checked? What if we haven't checked yet? Does it depend on whether we "trusted" the backup or not? How does it relate to getActiveSessionBackupVersion ?
There was a problem hiding this comment.
I copied the documentation of https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/rust-crypto/backup.ts#L111 since we are just calling this function.
…ypto-api-getbackupinfo
…ypto-api-getbackupinfo
florianduros
deleted the
florianduros/rip-out-legacy-crypto/add-crypto-api-getbackupinfo
branch
3 participants
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task element-hq/element-web#26922
Deprecated #4505 and we don't have any equivalent in the cryptoApi.
Add
CryptoApi.getBackupInfowhich is returning the key backup info the current key backup.I wrongly advised to use
CryptoApi.getActiveSessionBackupVersionwhich is returning the key backup version while we are expecting a key backup info.Test for the old crypto is useless but I need it to reach more than 80% coverage.