Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename crypto-api.ts -> crypto-api/index.ts #4283

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Rename crypto-api.ts -> crypto-api/index.ts #4283

merged 1 commit into from
Jun 26, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 26, 2024 •
edited
Loading

I found it quite confusing having CryptoApi be defined so far from the crypto-api folder.

@richvdh
Rename crypto-api.ts -> crypto-api/index.ts
f22ffc2 
I found it quite confusing having `CryptoApi` be defined so far from the
`crypto-api` folder.
@richvdh richvdh added the T-Task Tasks for the team like planning label Jun 26, 2024
@richvdh richvdh marked this pull request as ready for review June 26, 2024 15:36
@richvdh richvdh requested a review from a team as a code owner June 26, 2024 15:36
t3chguy
t3chguy approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think its a breaking change

@richvdh
Copy link
Member Author

richvdh commented Jun 26, 2024

LGTM but I think its a breaking change

Shouldn't be? import { foo } from "matrix-js-sdk/src/crypto-api"; should still work?

@t3chguy
Copy link
Member

t3chguy commented Jun 26, 2024

Shouldn't be? import { foo } from "matrix-js-sdk/src/crypto-api"; should still work?

Indeed, but import { foo } from "matrix-js-sdk/lib/crypto-api.js; would not. I believe ESM consumers have to import files like this

@richvdh
Copy link
Member Author

richvdh commented Jun 26, 2024

FML. Really?

It really feels like we need better tests for this stuff, if we're going to try and support it.

Maybe this isn't worthwhile, then.

@richvdh
Copy link
Member Author

richvdh commented Jun 26, 2024 •
edited
Loading

You're right, but it looks like ESM is borked anyway: #4287

@richvdh
Copy link
Member Author

richvdh commented Jun 26, 2024

... on which basis, I'm merging this without an X-Breaking-Change.

@richvdh richvdh added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit 65b9c31 Jun 26, 2024
36 checks passed
@richvdh richvdh deleted the rav/move_crypto_api branch June 26, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @t3chguy