Crypto: use a new error code for UTDs from device-relative historical events #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested review from
uhoreg,
BillCarsonFr,
florianduros and
MidhunSureshR
This was referenced Apr 3, 2024
|
Now updated |
richvdh
force-pushed
the
rav/historical_events/work
branch
from
3317eae
to
c5d03dd
Compare
... and a convenience method in PerSessionKeyBackupDownloader to access it.
... so that we don't need to remember to do it everywhere.
This doesn't have any effect on the tests, but *does* stop jest from hanging when you run the tests in in-band mode. It shouldn't *really* be needed, but using fake timers gives more reproducible tests, and I don't have the time/patience to debug why it is needed.
richvdh
force-pushed
the
rav/historical_events/work
branch
from
c5d03dd
to
38a508a
Compare
richvdh
force-pushed
the
rav/historical_events/work
branch
from
38a508a
to
d01ef4b
Compare
uhoreg
approved these changes
Apr 17, 2024
florianduros
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an event was sent before our device was created, and backup is not configured, we have no hope of decrypting it. To reflect this, use a different error code for the decryption failure.
Part of element-hq/element-meta#2313
Suggest review commit-by-commit