Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC3873 to handle escaped dots in push rule keys #3134

Merged
merged 26 commits into from
Mar 1, 2023
Merged

Implement MSC3873 to handle escaped dots in push rule keys #3134

merged 26 commits into from
Mar 1, 2023

Commits on Feb 8, 2023

  1. Add comments.

    @clokep
    clokep committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    1facb89 View commit details
    Browse the repository at this point in the history

  2. Implment MSC3873 to handle escaped dots in keys.

    @clokep
    clokep committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0600523 View commit details
    Browse the repository at this point in the history

  3. Add some comments about tests.

    @clokep
    clokep committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0ac33c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Merge remote-tracking branch 'upstream/develop' into dotted-keys

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9da576c View commit details
    Browse the repository at this point in the history

  2. Clarify spec behavior.

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f680ad8 View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    a23ed41 View commit details
    Browse the repository at this point in the history

  4. Don't manually iterate string.

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    704ed20 View commit details
    Browse the repository at this point in the history

  5. Clean-up tests.

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    0b9d896 View commit details
    Browse the repository at this point in the history

  6. Simplify tests.

    @clokep
    clokep committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    08144fa View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Add more tests & fix bug with empty parts.

    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b724cf1 View commit details
    Browse the repository at this point in the history

  2. Add more edge cases.

    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    7e11af8 View commit details
    Browse the repository at this point in the history

  3. Add a regular expression solution. 

    This is ~80% slower than the basic split(".").
    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    97fe8e9 View commit details
    Browse the repository at this point in the history

  4. Split on a simpler regular expression. 

    This is ~50% slower than a simple split(".").
    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    322913e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/develop' into dotted-keys

    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    7016e10 View commit details
    Browse the repository at this point in the history

  6. Remove redundant case in regex.

    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d7fcd36 View commit details
    Browse the repository at this point in the history

  7. Enable sticky regex.

    @clokep
    clokep committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c8a8f09 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Rollback use of regex.

    @clokep
    clokep committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    256cc92 View commit details
    Browse the repository at this point in the history

  2. Cache values in the PushProcessor.

    @clokep
    clokep committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    bdde4ef View commit details
    Browse the repository at this point in the history

  3. Use more each in tests.

    @clokep
    clokep committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d04d2a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Pre-calculate the key parts instead of caching them.

    @clokep
    clokep committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    e673f36 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/develop' into dotted-keys

    @clokep
    clokep committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d85806e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Fix typo.

    @clokep
    clokep committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    3c445f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Switch back to external cache, but clean out obsolete cached values.

    @clokep
    clokep committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ab9f212 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete property.

    @clokep
    clokep committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    fc66cec View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/develop' into dotted-keys

    @clokep
    clokep committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    cdb8760 View commit details
    Browse the repository at this point in the history

  4. Remove more obsolete properties.

    @clokep
    clokep committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    9e7c3c9 View commit details
    Browse the repository at this point in the history