Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fixed base64 in SAS verification #2320

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Apr 25, 2022

Implements MSC3783

Note: requires a new libolm. Do not merge until libolm version gets bumped. This PR now bumps the libolm version to the version that supports the required function


This change is marked as an internal change (Task), so will not be included in the changelog.

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me 👍

@uhoreg uhoreg marked this pull request as ready for review June 13, 2022 13:23
@uhoreg uhoreg removed the X-Blocked label Jun 13, 2022
@uhoreg uhoreg requested a review from germain-gg June 13, 2022 13:26
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants