Make self membership less prone to races#2277
Merged
robintown merged 1 commit intomatrix-org:developfrom Apr 6, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2277 +/- ##
===========================================
+ Coverage 58.99% 59.00% +0.01%
===========================================
Files 91 91
Lines 16337 16337
Branches 3768 3769 +1
===========================================
+ Hits 9638 9640 +2
+ Misses 6699 6697 -2
|
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 30, 2022
* Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 ([\matrix-org#2297](matrix-org#2297)). * Live location sharing - expose room liveBeaconIds ([\matrix-org#2296](matrix-org#2296)). * Support for MSC2457 logout_devices param for setPassword() ([\matrix-org#2285](matrix-org#2285)). * Stabilise token authenticated registration support ([\matrix-org#2181](matrix-org#2181)). Contributed by @govynnus. * Live location sharing - Aggregate beacon locations on beacons ([\matrix-org#2268](matrix-org#2268)). * Prevent duplicated re-emitter setups in event-mapper ([\matrix-org#2293](matrix-org#2293)). * Make self membership less prone to races ([\matrix-org#2277](matrix-org#2277)). Fixes element-hq/element-web#21661.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you tried to peek a room while the sync loop was still pulling in your own join event for that room, the peek could end up overwriting the synced membership with
null, causing the room to get stuck in a 'peeking' state. By bundling the call toupdateMyMembershipwithrecalculate, we ensure that it the actual latest membership value gets set.Type: defect
Closes element-hq/element-web#21661.
Here's what your changelog entry will look like:
🐛 Bug Fixes