Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an unstable prefix for MSC2885: Hidden read receipts #1788

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Use an unstable prefix for MSC2885: Hidden read receipts #1788

merged 3 commits into from
Jul 15, 2021

Conversation

SimonBrandner
Copy link
Contributor

We should be using an unstable prefix as per a4e5b45 (#2285)

@SimonBrandner
Use MSC2885 unstable prefix
9184a0d 
Signed-off-by: Šimon Brandner <[email protected]>
t3chguy
t3chguy approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks. Synapse doesn't support this anyway so not super critical :P

t3chguy
t3chguy requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THAT COULD HAVE BEEN A FUN ONE TO DEBUG

src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
SimonBrandner and others added 2 commits July 15, 2021 09:41
@SimonBrandner @t3chguy
Fix MSC number
ff40b4d 
Co-authored-by: Michael Telatynski <[email protected]>
@SimonBrandner @t3chguy
Fix MSC number
bae5650 
Co-authored-by: Michael Telatynski <[email protected]>
@SimonBrandner
Copy link
Contributor Author

@t3chguy, thanks for the massive save!

@t3chguy t3chguy merged commit 0601f98 into matrix-org:develop Jul 15, 2021
@SimonBrandner SimonBrandner deleted the feature/hidden-rrs branch July 15, 2021 07:47
@dbkr dbkr added the T-Task Tasks for the team like planning label Jul 15, 2021
@SimonBrandner SimonBrandner mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBrandner @t3chguy @dbkr