Refactor verification request code #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#11224
This extracts most of the verification request code from
crypto/index
and puts it into it's ownVerificationRequest
class with the specificities of whether to use to_device verification or verification over DM into aChannel
class. Care has been taken to maintain the same public API from the crypto module and the request object passed as an argument of the crypto.verification.request event.The next step will be add support for the
m.key.verification.ready
event, and to decorate verification events with averificationRequest
property and use this to drive toasts and verification timeline tiles in the react-sdk, removing theKeyVerificationStateObserver
.