Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the room ID from the space child state events. #1547

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

pixlwave
Copy link
Member

This property was removed in Synapse 1.65 as it was going against the spec.

For more info see matrix-org/synapse#13365 and element-hq/element-ios#6547.

This was removed in Synapse 1.65 as it was going against the spec.
@pixlwave pixlwave requested review from a team and SBiOSoftWhare and removed request for a team August 10, 2022 10:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/0.23.14@7a69ef4). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             hotfix/0.23.14    #1547   +/-   ##
=================================================
  Coverage                  ?   51.12%           
=================================================
  Files                     ?      515           
  Lines                     ?    84115           
  Branches                  ?    37497           
=================================================
  Hits                      ?    43007           
  Misses                    ?    39998           
  Partials                  ?     1110           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clokep
Copy link
Member

clokep commented Aug 15, 2022

For more info see matrix-org/synapse#13365

And element-hq/element-ios#5144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants