-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevX: Add Codecov #1502
DevX: Add Codecov #1502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice but I'm not sure this is going to generate the intended results. ElementX does 2 extra things:
1) Enables coverage data gathering on the main scheme https://github.com/vector-im/element-x-ios/blob/develop/ElementX/SupportingFiles/target.yml#L23
and
2) Exports the resulting coverage data in a format that Codecov understands (cobertura) https://github.com/vector-im/element-x-ios/blob/develop/fastlane/Fastfile#L93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
Continue to review full report at Codecov.
|
Part of element-hq/element-ios#6306
Used the same config file with https://github.com/vector-im/element-x-ios/blob/develop/codecov.yml, as i've no shining ideas to append atm.
If i'm correct Codecov will be able to comment on subsequent PRs after the base coverage is detected when this is merged. We should be able to see the difference also at https://app.codecov.io/gh/matrix-org/matrix-ios-sdk/pulls