Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevX: Add Codecov #1502

Merged
merged 7 commits into from
Jun 16, 2022
Merged

DevX: Add Codecov #1502

merged 7 commits into from
Jun 16, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 16, 2022

Part of element-hq/element-ios#6306

Used the same config file with https://github.com/vector-im/element-x-ios/blob/develop/codecov.yml, as i've no shining ideas to append atm.

If i'm correct Codecov will be able to comment on subsequent PRs after the base coverage is detected when this is merged. We should be able to see the difference also at https://app.codecov.io/gh/matrix-org/matrix-ios-sdk/pulls

@ismailgulek ismailgulek changed the title DevX: Add codecov DevX: Add Codecov Jun 16, 2022
@ismailgulek ismailgulek marked this pull request as ready for review June 16, 2022 10:44
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice but I'm not sure this is going to generate the intended results. ElementX does 2 extra things:
1) Enables coverage data gathering on the main scheme https://github.com/vector-im/element-x-ios/blob/develop/ElementX/SupportingFiles/target.yml#L23
and
2) Exports the resulting coverage data in a format that Codecov understands (cobertura) https://github.com/vector-im/element-x-ios/blob/develop/fastlane/Fastfile#L93

@ismailgulek ismailgulek marked this pull request as draft June 16, 2022 11:20
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@6f9cac7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1502   +/-   ##
==========================================
  Coverage           ?   11.66%           
==========================================
  Files              ?      507           
  Lines              ?    83158           
  Branches           ?    35522           
==========================================
  Hits               ?     9704           
  Misses             ?    73096           
  Partials           ?      358           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9cac7...141a485. Read the comment docs.

@ismailgulek ismailgulek marked this pull request as ready for review June 16, 2022 12:56
@ismailgulek ismailgulek merged commit a14a6be into develop Jun 16, 2022
@ismailgulek ismailgulek deleted the ismail/6306_devx branch June 16, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants