Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invite Room State Parsing #1148

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Topheee
Copy link

@Topheee Topheee commented Jul 4, 2021

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request updates CHANGES.rst
  • Pull request includes a sign off

Fixes

  • fixes JSON parsing of the _inviteRoomState property of MXEventUnsignedData

I ran into a parsing exception when my client was invited to a room created with

roomParameters.initialStateEvents = [MXRoomCreationParameters.initialStateEventForEncryption(withAlgorithm: kMXCryptoMegolmAlgorithm)]

The server implementation was Dendrite.

I didn't modify CHANGES.rst yet since it has no space resevered for a new release and I didn't want to introduce conflicts with other PRs.

Signed-off-by: Christopher Kobusch [email protected]

@pixlwave
Copy link
Member

Thanks for this contribution @Topheee, makes sense to me although I still need to test it. In the mean time, we have a new changelog entry format that has wiped out conflicts in our PRs. Please feel free to add one 😃

Ps sorry we have been slow to look at this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants