This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Don't query pasteboard contents until paste: #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuroe Could I get a review of this please? |
Adlai-Holler
force-pushed
the
pasteboard_fix
branch
from
b9c086f
to
c3f6158
Compare
|
@manuroe Updated with signoff & changelog. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
canPerformAction:causes a read of the pasteboard, which is annoying on iOS 14. The system alerts the user "Pasted from [x]" every time the menu is queried.Instead we can check the types without querying the contents.
Signed-off-by: Adlai Holler [email protected]