This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Add more flexibility to open links in other browsers, e.g. FF Mobile #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Müller <[email protected]>
|
What is wrong with this PR? Should I do something so that it can be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two app settings - httpHttpsBaseURL and httpHttpsQueryParam. With their help, browsers like Firefox can be supported. If httpHttpsBaseURL is present and httpLinkScheme/httpsLinkScheme doesn't have its default value, the URL is constructed as follows: httpHttpsBaseURL?httpHttpsQueryParam=url.
An example would be FF with httpHttpsBaseURL=firefox://open-url and httpHttpsQueryParam=url. The escaping is handled by NSURLComponents as setQueryItems is used.
Shall I add some predefined settings for applications to use (such as FF, Chrome, etc.)?
Closes #661
Signed-off-by: Maximilian Müller [email protected]