Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2758: Proposal for a common identifier grammar #2758

Merged
merged 5 commits into from
Oct 25, 2020
Merged

MSC2758: Proposal for a common identifier grammar #2758

merged 5 commits into from
Oct 25, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Sep 1, 2020 •
edited
Loading

@richvdh richvdh added proposal A matrix spec change proposal proposal-in-review labels Sep 1, 2020
@turt2live turt2live self-requested a review September 1, 2020 17:21
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Sep 1, 2020
@ara4n
Copy link
Member

ara4n commented Sep 1, 2020

lgtm

@richvdh @ara4n
fix typos
49e4e61 
Co-authored-by: Matthew Hodgson <[email protected]>
richvdh
richvdh commented Sep 2, 2020
View reviewed changes
proposals/2758-textual-id-grammar.md Outdated Show resolved Hide resolved
proposals/2758-textual-id-grammar.md Show resolved Hide resolved
turt2live
turt2live approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Thanks for writing it up - discussing in the room the other day was difficult for some reason :(

The timing isn't great, but widgets could benefit a lot from this.

proposals/2758-textual-id-grammar.md Show resolved Hide resolved
@richvdh
Copy link
Member Author

richvdh commented Sep 10, 2020

Part of me feels like this is ready for FCP, but also I don't want to have a bunch of completed MSCs (or worse, stuff in the spec) which isn't actually used (yet). So I'm minded to hold off on it until we have a usecase for it which is also ready for FCP.

@turt2live
Copy link
Member

We are in a position where we can run it against Widgets - we're in the spec PR stages for widgets, however its unique position allows for us to pile MSCs on top of the spec before it actually gets cut as a version.

@richvdh
Copy link
Member Author

richvdh commented Oct 9, 2020

Now that we have things like #2790 building on this, I think we should FCP this

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Oct 9, 2020 •
edited by ara4n
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Oct 9, 2020
@richvdh richvdh mentioned this pull request Oct 20, 2020
Closed
@mscbot
Copy link
Collaborator

mscbot commented Oct 20, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 20, 2020
@mscbot
Copy link
Collaborator

mscbot commented Oct 25, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 25, 2020
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Oct 25, 2020
@turt2live turt2live merged commit 4ee990e into master Oct 25, 2020
@turt2live turt2live mentioned this pull request Dec 15, 2020
Merged
@richvdh richvdh mentioned this pull request Dec 18, 2020
Merged
@richvdh richvdh mentioned this pull request Jan 20, 2021
Merged
@turt2live turt2live mentioned this pull request Mar 22, 2021
Open
@turt2live turt2live self-assigned this Apr 30, 2021
turt2live added a commit that referenced this pull request May 2, 2021
@turt2live
Definition of "Standard Identifier Format"
714cb67 
Spec for #2758
@turt2live turt2live mentioned this pull request May 2, 2021
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 2, 2021
@Cadair Cadair mentioned this pull request May 20, 2021
Closed
@richvdh richvdh mentioned this pull request Jun 15, 2021
Merged
@afranke afranke deleted the rav/proposals/textual_identifier_grammar branch September 22, 2021 10:37
richvdh pushed a commit that referenced this pull request Nov 30, 2021
@turt2live @richvdh
Definition of "Standard Identifier Format"
8804f4c 
Spec for #2758
richvdh pushed a commit that referenced this pull request Dec 15, 2021
@turt2live
Definition of "Standard Identifier Format" (#3171)
0fbc6bd 
Spec for #2758
@turt2live
Copy link
Member

This merged 14 days ago 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal left review comments

@Sorunome Sorunome Sorunome left review comments

@ara4n ara4n ara4n left review comments

@dbkr dbkr dbkr left review comments

@turt2live turt2live turt2live approved these changes

Assignees

@turt2live turt2live

Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richvdh @ara4n @turt2live @mscbot @dbkr @Sorunome @KitsuneRal