Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2409: Proposal to send EDUs to appservices #2409

Merged
merged 29 commits into from
Oct 28, 2024
Merged

MSC2409: Proposal to send EDUs to appservices #2409

merged 29 commits into from
Oct 28, 2024

Conversation

Sorunome
Copy link
Contributor

@Sorunome Sorunome commented Jan 14, 2020 •
edited by tulir
Loading

@turt2live turt2live added proposal A matrix spec change proposal proposal-in-review labels Jan 14, 2020
@turt2live turt2live mentioned this pull request Jan 14, 2020
Closed
@ericmigi
Copy link

bumping this up as it would help out of a ton of mx-puppet-slack users! :)

@MRAAGH
Copy link

MRAAGH commented Mar 3, 2020

I really miss this while using mx-puppet-discord. Typing notifications add so much extra value to a chat!

@auscompgeek
Copy link
Contributor

It seems to me that it would be worth making appservices opt into receiving EDUs to avoid pushing EDUs to an appservice that doesn't care about them.

@Half-Shot
Copy link
Contributor

@auscompgeek would be even better if appservices could add a filter to their registration data to filter out anything they don't care about.

@turt2live turt2live self-requested a review March 27, 2020 02:49
@Sorunome
Copy link
Contributor Author

Sorunome commented Apr 3, 2020

@Half-Shot maybe in general add the filter object to the registration file? That way PDUs could also be filtered. That sounds like it should be a separate MSC, though

@Half-Shot
Copy link
Contributor

@Half-Shot maybe in general add the filter object to the registration file? That way PDUs could also be filtered. That sounds like it should be a separate MSC, though

It was one from a while ago, but we dropped at the time as the performance gains from doing so weren't worth it.

@Sorunome
Copy link
Contributor Author

Sorunome commented Apr 3, 2020

@Half-Shot maybe in general add the filter object to the registration file? That way PDUs could also be filtered. That sounds like it should be a separate MSC, though

It was one from a while ago, but we dropped at the time as the performance gains from doing so weren't worth it.

Does it sound worthy to bring that up again, in relation with this MSC, and then leave filtering to, well, the filters?

@Half-Shot
Copy link
Contributor

Yup. I think it's worth noting that we might need filters, but at this point I think that's a seperate concern. This MSC is facilitating the ability for ASes to recieve EDU traffic, another MSC can handle filtering of that traffic.

@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020
@tulir tulir mentioned this pull request Jul 25, 2020
Open
turt2live
turt2live requested changes Aug 26, 2020
View reviewed changes
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
@Half-Shot Half-Shot mentioned this pull request Oct 1, 2020
Merged
@Half-Shot
Copy link
Contributor

Half-Shot commented Oct 1, 2020 •
edited
Loading

Implementing backend at matrix-org/synapse#8437 (available in 1.22.0)
Implementing bridge side at matrix-org/matrix-appservice-node#32 (available in 0.6.0)

@Half-Shot Half-Shot mentioned this pull request Oct 1, 2020
Merged
@tulir
Copy link
Member

tulir commented Oct 18, 2020

mautrix-python impl: mautrix/python@ee74e17

clokep
clokep reviewed Sep 30, 2024
View reviewed changes
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
@turt2live turt2live self-requested a review September 30, 2024 16:10
richvdh
richvdh reviewed Oct 1, 2024
View reviewed changes
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
tulir and others added 2 commits October 1, 2024 17:08
anoadragon453
anoadragon453 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small polish, but overall LGTM!

proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
proposals/2409-appservice-edus.md Show resolved Hide resolved
proposals/2409-appservice-edus.md Outdated Show resolved Hide resolved
@mscbot
Copy link
Collaborator

mscbot commented Oct 23, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Oct 23, 2024
@mscbot
Copy link
Collaborator

mscbot commented Oct 28, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Oct 28, 2024
@Half-Shot Half-Shot mentioned this pull request Oct 28, 2024
Open
3 tasks
@turt2live turt2live dismissed richvdh’s stale review October 28, 2024 15:50

subsequent review addressed concerns, I believe

@turt2live turt2live merged commit 853dc71 into matrix-org:old_master Oct 28, 2024
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Oct 28, 2024
turt2live added a commit that referenced this pull request Oct 28, 2024
@Sorunome @Half-Shot
@turt2live @kevincox @tulir @clokep @richvdh @anoadragon453
MSC2409: Proposal to send EDUs to appservices (#2409)
c1fc612 
* Initial proposal commit

* Add body of proposal

* rename file

* finish up MSC

* address issues

* change key names and add unstable prefix

* Clarifications; to-device handling

* It's not exactly like sync

* Move to-device messages

* Copy edu_type behaviour

* Add full transaction example

* Add implementation notes for to-device cleanup

* Use type instead of edu_type to match realities of implementations

* Add note to say ephemeral can be omitted.

* Improve wording on why we use a seperate array.

Co-authored-by: Kevin Cox <[email protected]>

* push_ephemeral -> receive_ephemeral

* Fix some typos and clarify EDU room association

* Clarify EDU formatting

* Explicitly list all event types

* Delete to-device events

to be moved to a new MSC

* Update spec link and fix typo

Co-authored-by: Patrick Cloke <[email protected]>

* Add private read receipt rules

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <[email protected]>

* Wrap lines

* Apply suggestions from code review

Co-authored-by: Andrew Morgan <[email protected]>

* Explicitly mention to-device events are not here

* Mention the possibility of more granular filtering

---------

Co-authored-by: Will Hunt <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Kevin Cox <[email protected]>
Co-authored-by: Tulir Asokan <[email protected]>
Co-authored-by: Patrick Cloke <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Andrew Morgan <[email protected]>
@matrixbot matrixbot mentioned this pull request Oct 31, 2024
Open
@zecakeh
Copy link
Contributor

zecakeh commented Nov 28, 2024

spec PR: matrix-org/matrix-spec#2018

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir left review comments

@Half-Shot Half-Shot Half-Shot left review comments

@richvdh richvdh richvdh left review comments

@uhoreg uhoreg uhoreg left review comments

@dbkr dbkr dbkr left review comments

@clokep clokep clokep left review comments

@kevincox kevincox kevincox left review comments

@auscompgeek auscompgeek auscompgeek left review comments

@cloudrac3r cloudrac3r cloudrac3r approved these changes

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@turt2live turt2live Awaiting requested review from turt2live

Assignees

@turt2live turt2live

@Half-Shot Half-Shot

Labels
kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review
Projects
Spec Core Team Backlog
Status: Requires spec writing
[Temp] SCT MSC intake board
Status: Scheduled - v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.