Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StrippedState schema is inconsistent #2066

Closed
jimmycuadra opened this issue Jun 2, 2019 · 0 comments · Fixed by #2067
Closed

StrippedState schema is inconsistent #2066

jimmycuadra opened this issue Jun 2, 2019 · 0 comments · Fixed by #2067
Assignees
@turt2live
Labels
client-server Client-Server API spec-bug Something which is in the spec, but is wrong

Comments

@jimmycuadra
Copy link
Contributor

According to r0.4.0 of the client-server StrippedState objects sometimes contain a required "sender" key and sometimes don't. I think the latter is probably an omission and it should always be required and present.

APIs where StrippedState includes the "sender" key:

APIs where StrippedState is missing the "sender" key:
@jimmycuadra jimmycuadra mentioned this issue Jun 2, 2019
Open
@turt2live turt2live added client-server Client-Server API spec-bug Something which is in the spec, but is wrong labels Jun 2, 2019
@turt2live turt2live self-assigned this Jun 2, 2019
turt2live added a commit that referenced this issue Jun 2, 2019
@turt2live
Clarify exactly what StrippedState is
7a07a6b 
Fixes #2066

The expectation everywhere is that the `sender` is required. `/initialSync` references StrippedState through a `m.room.member` event reference, and does not need editing.
@turt2live turt2live mentioned this issue Jun 2, 2019
Merged
@florianjacob florianjacob mentioned this issue Jun 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
client-server Client-Server API spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify exactly what StrippedState is matrix-org/matrix-spec-proposals
2 participants
@jimmycuadra @turt2live