Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget API extension: Always-on-screen #3810

Open
dbkr opened this issue Jul 3, 2018 · 15 comments
Open

Widget API extension: Always-on-screen #3810

dbkr opened this issue Jul 3, 2018 · 15 comments
Assignees
@turt2live
Labels
blocked Something needs to be done before action can be taken on this PR/issue. integrations Integration (Manager) API kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review widgets anything to do with widgets

Comments

@dbkr
Copy link
Member

dbkr commented Jul 3, 2018 •
edited by anoadragon453
Loading

Documentation: https://docs.google.com/document/d/1_HEq5skPp1Yp559hYp2FSO2ecw8mJQR8lOvgsmYOEro/edit?usp=sharing

Implementation(s):

An extension to the widgets API to allow widgets to remain on screen whatever room the user is viewing. Current use case is video calls.
@turt2live
Copy link
Member

I'm not sure there'd need to be any changes to the widget API from a spec perspective. What did you have in mind?

@dbkr
Copy link
Member Author

dbkr commented Jul 3, 2018

Hopefully the proposal explains all :)

@turt2live
Copy link
Member

Ah, I see. It's a capability being requested by the widget. That makes a lot more sense :D

@turt2live
Copy link
Member

note: this is built upon the currently undocumented widget API (#1236)

Looks good to me :)

@rxl881
Copy link
Contributor

rxl881 commented Jul 4, 2018

Looks good to me, @dbkr. Thanks!

@turt2live turt2live added the proposal A matrix spec change proposal label Jul 10, 2018
dbkr referenced this issue in matrix-org/matrix-react-sdk Jul 11, 2018
@dbkr
Implement always-on-screen capability for widgets
8f10ee0 
As per https://github.com/matrix-org/matrix-doc/issues/1354

This is whitelisted to only jitsi widgets for now as per comment,
mostly because any widget that we may make always-on-screen we need
to preemptively put in a PersistedElement container, which is
unnecessary for any other widget.

Apologies that this does a bunch of refactoring which could have
been split out separately: I only discovered what needed to be
refactored in the process of doing this.

Fixes element-hq/element-web#6984
This was referenced Jul 11, 2018
Merged
Merged
@turt2live
Copy link
Member

In the interest of getting this into the integration spec:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Dec 17, 2018 •
edited by richvdh
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot
Copy link
Collaborator

mscbot commented Dec 24, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot
Copy link
Collaborator

mscbot commented Dec 30, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live self-assigned this Feb 6, 2019
@turt2live turt2live added the integrations Integration (Manager) API label Jun 20, 2019
@Johni0702 Johni0702 mentioned this issue Nov 18, 2019
Open
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 21, 2020
@turt2live turt2live mentioned this issue Sep 2, 2020
Draft
6 tasks
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review widgets anything to do with widgets labels Nov 23, 2020
@sunnyharsh123

This comment has been minimized.

Sign in to view
@SimonBrandner

This comment has been minimized.

Sign in to view
@turt2live turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Apr 6, 2021
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@toger5
Copy link

toger5 commented Dec 28, 2021

I think this is now implemented right? (the example in the matrix-widget-api is using a sticky widget)

@toger5 toger5 removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 28, 2021
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 28, 2021
@turt2live
Copy link
Member

It's not linked in the description here.

@toger5
Copy link

toger5 commented Dec 28, 2021

I was thinking about this line: https://github.com/matrix-org/matrix-widget-api/blob/b571e1860903b3ef712b62380f042b6ad9b5611f/examples/widget/index.html#L96

I though this would be the implementation of the Widget Api extension. Probably I got the meaning of needs-implementation wrong then.

@anoadragon453
Copy link
Member

That looks like a valid implementation to me. I believe @turt2live meant that it needs to be specified in the description of the original comment in order for the needs-implementation label to be removed.

I've added it, and am removing the label. Feel free to re-add if the implementation isn't satisfactory.

@anoadragon453 anoadragon453 removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Feb 1, 2022
@ShadowJonathan ShadowJonathan mentioned this issue Feb 6, 2022
Open
@jryans jryans mentioned this issue Feb 7, 2022
Closed
@turt2live turt2live mentioned this issue Dec 17, 2018
Open
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@ara4n ara4n transferred this issue from matrix-org/matrix-spec May 9, 2022
@dhenneke dhenneke mentioned this issue Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
blocked Something needs to be done before action can be taken on this PR/issue. integrations Integration (Manager) API kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review widgets anything to do with widgets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dbkr @turt2live @anoadragon453 @richvdh @rxl881 @toger5 @SimonBrandner @mscbot @sunnyharsh123