This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Stabilise and document the new account management options #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
added
A-Configuration
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
fe9171d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59997bc3.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-stabilize-options.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/stabilize-options
branch
from
72e7179 to
df206c3
Compare
reivilibre
approved these changes
Aug 1, 2024
| /// Whether email-based password recovery is enabled. Defaults to `false`. | ||
| /// | ||
| /// This has no effect if password login is disabled. | ||
| #[serde(default = "default_false", skip_serializing_if = "is_default_false")] |
There was a problem hiding this comment.
hmm, why disable this by default?
There was a problem hiding this comment.
Because it's a way to take over accounts, so you need to trust your email sending pipeline, which makes me hesitant to enable by default?
sandhose
force-pushed
the
quenting/stabilize-options
branch
from
b63c1a9 to
fe9171d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2884
This also changes one default behavior: registration is now disabled by default.