Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Deactivate user admin API #3030

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Jul 30, 2024

This adds an admin API to deactivate users

Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36d5963
Status: ✅  Deploy successful!
Preview URL: https://4885a046.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-admin-api-user-deac.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose added the A-Admin-API Related to the admin API label Jul 30, 2024
@sandhose sandhose force-pushed the quenting/admin-api/user-deactivate branch from b1b85e7 to 476a5ad Compare July 30, 2024 09:48
@sandhose sandhose force-pushed the quenting/admin-api/temp-merge-base branch from f382846 to cc10495 Compare July 30, 2024 15:48
@sandhose sandhose force-pushed the quenting/admin-api/user-deactivate branch 2 times, most recently from 2858840 to 73e0f9c Compare August 1, 2024 14:31
@sandhose sandhose changed the base branch from quenting/admin-api/temp-merge-base to main August 1, 2024 14:31
@sandhose sandhose marked this pull request as ready for review August 1, 2024 14:38
@sandhose sandhose requested a review from reivilibre August 1, 2024 14:38
@sandhose sandhose mentioned this pull request Aug 2, 2024
13 tasks
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

);

// It should have scheduled a deactivation job for the user
// XXX: we don't have a good way to look for the deactivation job
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should return an identifier for the job. That way, scripts that need to could wait for the job to complete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like something like that if we rewrite the job system (#2785)

@sandhose sandhose force-pushed the quenting/admin-api/user-deactivate branch from 73e0f9c to 36d5963 Compare August 6, 2024 09:39
@sandhose sandhose enabled auto-merge (rebase) August 6, 2024 09:40
@sandhose sandhose merged commit 117e124 into main Aug 6, 2024
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Admin-API Related to the admin API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants