This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with Cloudflare Pages
|
sandhose
force-pushed
the
quenting/admin-api/user-deactivate
branch
from
July 30, 2024 09:48
b1b85e7
to
476a5ad
Compare
sandhose
force-pushed
the
quenting/admin-api/temp-merge-base
branch
from
July 30, 2024 15:48
f382846
to
cc10495
Compare
sandhose
force-pushed
the
quenting/admin-api/user-deactivate
branch
2 times, most recently
from
August 1, 2024 14:31
2858840
to
73e0f9c
Compare
sandhose
changed the base branch from
quenting/admin-api/temp-merge-base
to
main
August 1, 2024 14:31
reivilibre
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
); | ||
|
||
// It should have scheduled a deactivation job for the user | ||
// XXX: we don't have a good way to look for the deactivation job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should return an identifier for the job. That way, scripts that need to could wait for the job to complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like something like that if we rewrite the job system (#2785)
sandhose
force-pushed
the
quenting/admin-api/user-deactivate
branch
from
August 6, 2024 09:39
73e0f9c
to
36d5963
Compare
This was referenced Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an admin API to deactivate users