This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Account Recovery: replace the server-side rendered form with an interactive React-based form #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
8e2c304
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de7e1254.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-fe-pwrecovery.matrix-authentication-service-docs.pages.dev |
sandhose
approved these changes
Jul 26, 2024
| @@ -6,7 +6,8 @@ | |||
| "close": "Close", | |||
| "continue": "Continue", | |||
| "edit": "Edit", | |||
| "save": "Save" | |||
| "save": "Save", | |||
| "save_and_continue": "Save and continue" | |||
There was a problem hiding this comment.
The action.* namespace is shared with EW/EX, so I think we have to be slightly careful here. That key does not exist there yet, but it looks alright and fine to share. @t3chguy opinions?
There was a problem hiding this comment.
if the text exists in Figma and seems a short reusable action such as this then I think its the right way to do it
| response.data?.setPasswordByRecovery.status === SetPasswordStatus.Allowed | ||
| ) { | ||
| // TODO HOW DO WE NAVIGATE | ||
| router.navigate({ to: "/../login" }); |
There was a problem hiding this comment.
Honestly window.location.href = '/login' might be fine. Part of the annoying thing here is getting the exact app root, as MAS might be mounted on a subpath.
Maybe the best we can do is load the react app root (aka /account) but with a full page load so that the backend takes care of redirecting us to /login, so something like
const router = useRouter(); // not in the if, because of the rules of hooks
const location = router.buildLocation({ to: "/" });
window.location.href = location.href;Replace with the React frontend form
reivilibre
force-pushed
the
rei/fe_pwrecovery
branch
from
544b85d to
8e2c304
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #172: the interactive form has a live-feedback meter for password complexity
TODO (would like your help please):
commit by commit :-)