This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Rework assets loading to fix splitting CSS chunks #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
81b74fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73590f37.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-merge-assets.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/merge-assets
branch
from
affe69f to
81b74fc
Compare
reivilibre
approved these changes
Jul 25, 2024
Comment on lines
-29
to
-41
| (function () { | ||
| const query = window.matchMedia("(prefers-color-scheme: dark)"); | ||
| function handleChange(list) { | ||
| if (list.matches) { | ||
| document.documentElement.classList.add("cpd-theme-dark"); | ||
| } else { | ||
| document.documentElement.classList.remove("cpd-theme-dark"); | ||
| } | ||
| } | ||
|
|
||
| query.addEventListener("change", handleChange); | ||
| handleChange(query); | ||
| })(); |
There was a problem hiding this comment.
do we not support dark colour themes anymore? Or is this handled some other way?
There was a problem hiding this comment.
We do, it's me who misunderstood how the design tokens worked at some point. It defaults to media queries, but you can override the theme by setting the cpd-theme-dark or cpd-theme-light classes.
So this piece of code isn't needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I had a re-read of the Vite documentation, and applied exactly what they suggest for including assets.
This fixes CSS code splitting, so we can now share most of the CSS between the server-side rendered templates and the SPA