-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
Deploying matrix-authentication-service-docs with Cloudflare Pages
|
just for ref, do you have a link to the designs / an issue, in case we need to look back on this in the future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems fine to me. Glad we split up the filters like that
/// A filter for dates, with a lower bound and an upper bound | ||
#[derive(InputObject, Default, Clone, Copy)] | ||
pub struct DateFilter { | ||
/// The lower bound of the date range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what gets generated as the GraphQL documentation right?
I think we should describe the format of the date here, since it's not obvious how a caller should use it.
I then wonder how much we care about timezones. Possibly not at all, given 90 days is far enough away that it probably doesn't matter whether it's a few hours off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scalar used is a custom one, which is serialises as a string, and has the following (autogenerated) documentation on it:
"""
Implement the DateTime<Utc> scalar
The input/output is a string in RFC3339 format.
"""
scalar DateTime
so that's probably fine?
You're right, for the feature itself that would be #2219 The designs are here: https://www.figma.com/design/HUysJAhv6cK6p1Pc81Fxaa/Matrix-Authentication-Service-(MAS)?node-id=4352-32522&t=lqvaJRtBgVVCC7Ix-4 Tracking issue for the designs: #2265 |
This is reviewable commit by commit:
This adds a filter to only show sessions that have not been active for more than 90 days.
It also reworks a bit the session list to make it clearer that the browser session thing is separate.
On the frontend side, it isn't exactly what's designed, because:
Fixes #2219
Helps with #2265