This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Code-split the password change route #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
d57cff2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a3dbdf3.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-code-split-password.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/code-split-password
branch
from
cf7f848 to
d57cff2
Compare
reivilibre
approved these changes
Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code-splits the password change page, as it loads a lot of dictionaries for password strength estimation.
It also fixes a bug where the field would should that the password is not strong enough because it got auto-filled by the browser.