This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Mark sessions as finished in bulk #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
334acad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b58b89a1.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-batch-logout.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/user-reactivation
branch
from
3f30498 to
6c0effd
Compare
sandhose
force-pushed
the
quenting/batch-logout
branch
from
b425f9b to
7526713
Compare
reivilibre
approved these changes
Jul 16, 2024
| let (sql, arguments) = Query::update() | ||
| .table(CompatSessions::Table) | ||
| .value(CompatSessions::FinishedAt, finished_at) | ||
| .and_where_option(filter.user().map(|user| { |
There was a problem hiding this comment.
should the CompatSessionFilter be responsible for constructing its own WHERE clauses? I am a bit concerned we'd forget to update this code here if we added more to the filter
There was a problem hiding this comment.
I did think of this, but it was annoying in particular for the compatibility sessions, as when we query, we JOIN on the compat_sso_logins and filter on that, which we can't do for updating the finished_at field.
I'll have a shot though in another PR
sandhose
force-pushed
the
quenting/batch-logout
branch
from
7526713 to
21ed451
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reviewable commit by commit.
On top of #2970
mas-cli manage kill-sessionsfinish sessions in bulkThis makes it so that when we finish sessions (like when deactivating a user), we can do that in bulk.
This introduces new APIs on the three repositories, which are then used by the
mas-cli manage kill-sessionscommand.The reason we need this, is so that we can kill all sessions when a user is deactivated, so that they don't leave active sessions behind, and don't get magically logged in once we reactivate them.