This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Hyper 1.x #2944
Merged
Hyper 1.x #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
17e639e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76caa52f.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-hyper-1.matrix-authentication-service-docs.pages.dev |
We removed here the Timeout layer on the HTTP client service, because it required the body to be Default, which isn't the case anymore. Not sure what to do about it.
This also replaces the init_tracing test helper with a general setup test helper, so that it also initializes the rustls crypto backend.
This does a few things: - move `bytes` to workspace dependencies - write an hyper-based transport for Sentry - ignore OTEL errors related to propagations - fix everything else in mas-cli
reivilibre
approved these changes
Jul 4, 2024
sandhose
added
A-Dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit messy, because this upgrade touches a lot of things…
Other than basic renames/traits bound changes, there are a bunch of interesting changes:
mas-iana-codegen, I switched to just usereqwestfor doing the HTTP requests. It's codegen, doesn't really matter if it gets in the treemas-listenerwill accept unencrypted HTTP/2 connections, not just over TLSrustlsupgrade means we're now have to explicitly initialise the crypto backend, including in testsopentelemetry-httpis still on http 0.2, so I had to rewrite theHeaderInjector,HeaderExtractorand an implementation ofopentelemetry_http::HttpClientbased on hyper 1.x (which is annoying because we have to transform[email protected]::Requesttohttp@1::Request, andhttp@1::Responseto[email protected]::Response. Hopefully they'll migrate to http/hyper 1.x soon enoughclientfeatures ofmas-oidc-client, as it's not really used by anyoneIt's somewhat reviewable PR by PR, I tried to not make one huge commit and have somewhat sensible commit message, but this was a bit a mess to work on :(