This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Make the b64decode filter try multiple base64 encoding variants #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
fe6b3ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abeb80e9.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-flexible-base64-dec.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Jun 28, 2024
| ) | ||
| .with_source(e) | ||
| })?; | ||
| // We're not too concerned about the performance of this filter, so we'll just |
There was a problem hiding this comment.
This feels a bit lax TBH, I'm not sure about the intended usage but this is the kind of thing that makes you accidentally accept something you didn't mean to and then make it hard to break that later.
If we're really sure this is fine then fine, but otherwise I'd prefer to have different filters for the different variants
There was a problem hiding this comment.
This can be used when transforming attributes from an upstream IDP. We use this for decoding the Dex subject in ESS, and as we're not documenting this, I think it'll be fine if we want to break it later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was sometimes a problem when decoding the subject given by Dex