-
Notifications
You must be signed in to change notification settings - Fork 32
Better organise the documentation, document the policy engine, the authorisation process and the scopes #2637
Conversation
Deploying matrix-authentication-service-docs with Cloudflare Pages
|
a53b6d6
to
e367e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for adding this detailed documentation
b278ce4
to
31a8add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nicely organised documentation and easy to read.
@@ -5,7 +5,13 @@ This documentation is intended to give an overview of how the `matrix-authentica | |||
The documentation itself is built using [mdBook](https://rust-lang.github.io/mdBook/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the first sentence in the readme, would it be worth adding what MAS actually is, in a short sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a few words, mostly copied from the repo README 👍
- [`manage`](./reference/cli/manage.md) | ||
- [`server`](./reference/cli/server.md) | ||
- [`templates`](./reference/cli/templates.md) | ||
- [`doctor`](./reference/cli/doctor.md) | ||
|
||
# Development | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the 'Application Services login' be under a section? Feels like a bit of an orphan at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed a bit lonely, its main purpose is to have a link from the README to have a disclaimer on the state of ASes. I think I'll leave it as-is for now
This adds a few section to the documentation:
Fixes #2187
Part of #2605
This also reorganises the documentation to have basically 4 parts:
I also want to add more "how-to" tutorials, really task-oriented, but I'll add some of them in another PR.