Skip to content
This repository was archived by the owner on Sep 10, 2024. It is now read-only.

fix(register.rego): increase allowed username length to 64 #2471

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

AlexanderBabel
Copy link
Contributor

This PR addresses the issue #2454

Reason

The current username limit of 14 characters feels arbitrary and I did not find any reason for that limit.

I checked the following components:

  • MAS Database: The column username in users is of type text and hence not limiting the username length.
  • Synapse: To test a long username, I created a new account on matrix.org with a username that is 64 characters long. It worked without any issues.

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm not sure it's even worth having this limit at all, but in the meantime bumping that to 64 characters makes sense

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants