This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Ask Homeserver for username availability upon registration #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3e458a1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6fb15905.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-check-username-avai.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/check-username-availability
branch
from
2cee764 to
0794f2d
Compare
sandhose
added
A-GraphQL
This calls the HS to make sure the username isn't reserved. This check can be bypassed using the `skipHomeserverCheck` flag on the `addUser` mutation.
sandhose
force-pushed
the
quenting/check-username-availability
branch
from
3e458a1 to
508382a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2376
Whenever MAS register a user, from the registration form, the upstream OAuth 2.0 registration or the GraphQL API, it now ask the homeserver whether the username is available.
This makes sure a user doesn't accidentally register with a username used by an internal account or by an application service.
This check can be bypassed on the GraphQL API by administrators using the new
skipHomeserverCheckflag.This can be reviewed commit-by-commit.