This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Make sure the dummy router finished loading in the test environment #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
be47076
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bfab921a.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-dummy-rout.matrix-authentication-service-docs.pages.dev |
t3chguy
reviewed
Feb 27, 2024
sandhose
force-pushed
the
quenting/frontend/dummy-router-load
branch
from
f60932c to
be47076
Compare
t3chguy
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't figure out why it was the case, maybe a bug in @tanstack/router, but sometimes the router would render an empty
<div>instead of its children.This adds a
router.load()call in the router test utility, and exports arouterReadypromise which resolves when the router is ready to be used.The big diff is because we had empty snapshots because of this. 🤦