This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Better session list #2393
Merged
Better session list #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
added
A-Frontend
Deploying with
|
| Latest commit: |
9cff44a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c96e815.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-better-ses-9o12.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/frontend/better-session-list
branch
from
a740d2b to
62ea471
Compare
sandhose
changed the base branch from
main
to
quenting/frontend/dummy-router-load
sandhose
force-pushed
the
quenting/frontend/dummy-router-load
branch
from
f60932c to
be47076
Compare
sandhose
force-pushed
the
quenting/frontend/better-session-list
branch
3 times, most recently
from
3e8be6f to
ecb698d
Compare
sandhose
changed the base branch from
quenting/frontend/dummy-router-load
to
main
sandhose
force-pushed
the
quenting/frontend/better-session-list
branch
from
ecb698d to
44cd354
Compare
sandhose
force-pushed
the
quenting/frontend/better-session-list
branch
from
44cd354 to
9cff44a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the new user agent parsing on the server side to display a nice list of sessions.
It also simplifies the code a lot, removing dead code
One thing to look at when reviewing, is how the nested anchors are implemented. I had to put the "Sign out" button outside the main card link, with an absolute position. This also means I had to put a right padding on the card title to make the card title overflow correctly.
Design reference: https://www.figma.com/file/HUysJAhv6cK6p1Pc81Fxaa/Matrix-Authentication-Service-(MAS)?type=design&node-id=4345-14104&mode=design&t=0PyGBuKAJs7KhVgL-4
Story to see the card live: https://quenting-frontend-better-ses-9o12.matrix-authentication-service-docs.pages.dev/storybook/?path=/docs/ui-session-card--docs