This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Move the cross-signing reset to its own page #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6431d14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d85680bb.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-cross-sign.matrix-authentication-service-docs.pages.dev |
This is done by making it possible to render the GenericError, Layout and Footer with a `dontSuspend` prop. This then sets the `useSuspense` to `false` in translations, and sets a default translations in case they haven't been loaded yet.
This makes sure that the loader stops loading when navigating away
sandhose
force-pushed
the
quenting/frontend/cross-signing
branch
2 times, most recently
from
30327cb to
4fa7888
Compare
t3chguy
approved these changes
Feb 17, 2024
sandhose
force-pushed
the
quenting/frontend/cross-signing
branch
from
4fa7888 to
6431d14
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of small issues, see each commit:
Also adds a deep-link to the page, via
?action=org.matrix.cross_signing_resetThe
Backbutton goes back home, and if the user got to this page via deep-linking, the back button gets awat