This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was unnecessarily complicated.
This replaces everything which used jotai-urql with just urql calls.
Next step is to replace the custom jotai-based router with tanstack router, but I prefer to do that in a second PR to make it easier to review.
For reviewers, most interesting changes are:
src/app.tsx
, the app root now loads the current user ID to allow giving a non-nullable user ID down the component tree, and avoid having a "is the user ID null" logic in every routeresult.error
is set and handle the error in the nearest error boundaryurql
doesn't know it runs in suspense mode in its typings, soresult.data
is nullable, which should never happen unlessresult.error
is set. So there is a lot of:src/pagination.tsx
for the hooks, andsrc/components/BrowserSessionList.tsx
for an example usage