Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Allow config dump to generate to a file directly instead of stdout #2146 #2234

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Jan 4, 2024

It is a little bit copy&paste from

Writing the dump to the file system is only consequent.

I am not very familiar with rust to bring it in a seperate function for deduplicated code.

@dklimpel
Copy link
Contributor Author

dklimpel commented Jan 4, 2024

I am not sure if the failing pipeline is my fault:

error[vulnerability]: Some Ref methods are unsound with some type parameters
    ┌─ /github/workspace/Cargo.lock:[54](https://github.com/matrix-org/matrix-authentication-service/actions/runs/7408315024/job/20156268314?pr=2234#step:4:55)3:1
    │
543 │ zerocopy 0.7.26 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2023-0074
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0074
    = The `Ref` methods `into_ref`, `into_mut`, `into_slice`, and `into_slice_mut` are unsound
      and may allow safe code to exhibit undefined behavior when used with `Ref<B, T>` where `B`
      is [`cell::Ref`](https://doc.rust-lang.org/core/cell/struct.Ref.html) or
      [`cell::RefMut`](https://doc.rust-lang.org/core/cell/struct.RefMut.html). Note that these
      methods remain sound when used with `B` types other than `cell::Ref` or `cell::RefMut`.

@sandhose
Copy link
Member

sandhose commented Feb 2, 2024

Thanks! CI failures was solved in another PR, so I'm going to merge main in your branch to fix it

@sandhose sandhose enabled auto-merge (rebase) February 2, 2024 16:55
@sandhose sandhose merged commit 979062d into matrix-org:main Feb 2, 2024
16 of 17 checks passed
@dklimpel dklimpel deleted the dump_output branch February 2, 2024 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants